From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: submit nvme_admin_activate_fw to admin queue
Date: Wed, 14 Jun 2017 08:27:00 +0200 [thread overview]
Message-ID: <20170614062700.GA8929@lst.de> (raw)
In-Reply-To: <1497389810-19303-1-git-send-email-dmilburn@redhat.com>
On Tue, Jun 13, 2017@04:36:50PM -0500, David Milburn wrote:
> The nvme_admin_activate_fw command should be submitted to
> the admin queue; otherwise, mode 0x0F (ACTIVATE_DEFERRED_MICROCODE)
> and mode 0x05 (DOWNLOAD_SAVE_ACTIVATE) will fail.
>
> Fixes: b90c48d0c11ef("nvme: split nvme_trans_send_fw_cmd")
> Reported-by: Joseph Szczypek <joseph.szczypek at hpe.com>
> Tested-by: Micah Parrish <micah.parrish at hpe.com>
> Signed-off-by: David Milburn <dmilburn at redhat.com>
If this command has been broken all the time we should just remove it.
next prev parent reply other threads:[~2017-06-14 6:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 21:36 [PATCH] nvme: submit nvme_admin_activate_fw to admin queue David Milburn
2017-06-14 6:27 ` Christoph Hellwig [this message]
2017-06-15 9:15 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614062700.GA8929@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox