From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: Remove SCSI translations
Date: Wed, 14 Jun 2017 17:37:54 +0200 [thread overview]
Message-ID: <20170614153754.GA13038@lst.de> (raw)
In-Reply-To: <1497452191-11429-1-git-send-email-keith.busch@intel.com>
On Wed, Jun 14, 2017@10:56:31AM -0400, Keith Busch wrote:
> The SCSI-to-NVMe translations were added to assist storage applications
> utilizing SG_IO transitioning to NVMe. It was always recommended, however,
> to use native NVMe for device management: too much is lost in translation
> and the maintenance burden in keeping this kludgey layer around has been
> neglected such that much of the translations are completely broken.
>
> This patch removes SG_IO handling from NVMe. The config option has been
> disabled by default for quite some time now, so hopefully it's safe to
> remove. If not, this will force people to do the right thing.
>
> Signed-off-by: Keith Busch <keith.busch at intel.com>
I like this but would like to hear from the SuSE folks first
as indicated in the other mail.
Also at least the nvme_get_log_page and nvme_set_features functions
in core.c are unused after this patch and can be removed as well.
next prev parent reply other threads:[~2017-06-14 15:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 14:56 [PATCH] nvme: Remove SCSI translations Keith Busch
2017-06-14 14:50 ` Jens Axboe
2017-06-14 15:17 ` Martin K. Petersen
2017-06-14 15:37 ` Christoph Hellwig [this message]
2017-06-15 9:18 ` Sagi Grimberg
2017-06-15 9:47 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614153754.GA13038@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox