Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme-pci: another 64-bit division for the host memory buffer code
Date: Thu, 15 Jun 2017 14:10:47 +0200	[thread overview]
Message-ID: <20170615121047.GA23200@lst.de> (raw)
In-Reply-To: <deaabdf8-40a2-7ecd-b874-bdf7fdc0438e@grimberg.me>

On Thu, Jun 15, 2017@11:55:28AM +0300, Sagi Grimberg wrote:
> This looks fine, but is there a good reason why
> shouldn't DIV_ROUND_UP take care of that instead of you
> open-coding it?

Because it uses a plain division, and Linux on most 32-bit architectures
doesn't support that, as Linus doesn't want the required libgcc helpers
in the kernel.

  reply	other threads:[~2017-06-15 12:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-13 15:31 [PATCH] nvme-pci: another 64-bit division for the host memory buffer code Christoph Hellwig
2017-06-15  8:55 ` Sagi Grimberg
2017-06-15 12:10   ` Christoph Hellwig [this message]
2017-06-15 17:04 ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170615121047.GA23200@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox