From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Mon, 19 Jun 2017 14:35:20 +0200 Subject: [PATCH rfc 02/30] nvme-rdma: Don't alloc/free the tagset on reset In-Reply-To: <4b612cf9-f8ba-f2fa-8f93-c2c46468daf4@grimberg.me> References: <1497799324-19598-1-git-send-email-sagi@grimberg.me> <1497799324-19598-3-git-send-email-sagi@grimberg.me> <20170619071851.GB13168@lst.de> <4b612cf9-f8ba-f2fa-8f93-c2c46468daf4@grimberg.me> Message-ID: <20170619123520.GC29061@lst.de> > We can do that, but this tries to eliminate duplicate code as > much as possible. It's not like the convention is unprecedented... It's fairly nasty to follow. OTOH I like your overall cleanup, so I guess I shouldn't complain about the initial patches to much but just possibly do another pass after you are done..