Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
Subject: remove long broken SCSI to NVMe translations
Date: Mon, 19 Jun 2017 23:48:00 -0700	[thread overview]
Message-ID: <20170620064800.GA11019@infradead.org> (raw)
In-Reply-To: <5943E3BC.6050807@hpe.com>

On Fri, Jun 16, 2017@09:57:16AM -0400, Linda Knippers wrote:
> > Everything that could be done using the scsi emulation can be trivially
> > done using nvme-cli, as they should have done from day 0.
> 
> I don't quite know the history of our use of the scsi translation but I
> suspect it's because we adapted some existing utility to also support nvme.
> 
> David Milburn's patch is very simple.  Can we please fix the bug for now
> so we have a little time to fix our tools?

I don't think I want to expand usage of it.  The code only "worked"
for about two years, during which not too many NVMe products even
existed.  And I say "worked" because I found countless of sever bugs
(use after free, memory overruns, etc) issues when I first ran a SCS
I testsuite over it, which obviously didn't even cover the commands
you care about.

You might have a slightly better leaverage with distros already
shipping this code, but enabling it upstream does not seem in any
way helpful.

  reply	other threads:[~2017-06-20  6:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-14  6:35 remove long broken SCSI to NVMe translations Christoph Hellwig
2017-06-14  6:35 ` [PATCH 1/2] nvme-scsi: remove TEST UNIT READY emuation Christoph Hellwig
2017-06-14  6:35 ` [PATCH 2/2] nvme-scsi: remove FORMAT UNIT and WRITE BUFFER emulations Christoph Hellwig
2017-06-14 15:00 ` remove long broken SCSI to NVMe translations Keith Busch
2017-06-14 15:01   ` Christoph Hellwig
2017-06-16  6:11     ` Hannes Reinecke
2017-06-16  8:31       ` Christoph Hellwig
2017-06-16 13:57         ` Linda Knippers
2017-06-20  6:48           ` Christoph Hellwig [this message]
2017-06-20 14:27           ` Keith Busch
2017-06-22 18:31         ` Micah Parrish
2017-06-22 19:21           ` Johannes Thumshirn
2017-06-30 13:07             ` Judy Brock
2017-06-14 15:14   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170620064800.GA11019@infradead.org \
    --to=hch@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox