From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH nvme-cli] fabrics: add hostid option to connect command
Date: Tue, 20 Jun 2017 14:31:02 +0200 [thread overview]
Message-ID: <20170620123102.GA25762@lst.de> (raw)
In-Reply-To: <20170620122556.10271-1-jthumshirn@suse.de>
On Tue, Jun 20, 2017@02:25:56PM +0200, Johannes Thumshirn wrote:
> Add an option to pass in the hostid either via command line or a new config
> file /etc/nvme/hostid.
Looks great!
Reviewed-by: Christoph Hellwig <hch at lst.de>
I think we should also add code to generate a default hostid somewhere.
I guess we could just uuidgen(1) and drive it from the package? Sagi
added a call to genhostnqn to the specfile, so that should go into
it as well.
(and it seems like Debian packaging isn't present at all in the
package)
next prev parent reply other threads:[~2017-06-20 12:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 12:25 [PATCH nvme-cli] fabrics: add hostid option to connect command Johannes Thumshirn
2017-06-20 12:31 ` Christoph Hellwig [this message]
2017-06-20 12:34 ` Johannes Thumshirn
2017-06-20 12:36 ` Christoph Hellwig
2017-06-20 12:37 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620123102.GA25762@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox