Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: nvme defintions not used in the kernel
Date: Thu, 29 Jun 2017 15:31:59 +0200	[thread overview]
Message-ID: <20170629133159.GA10896@lst.de> (raw)
In-Reply-To: <20170629083228.GE3808@linux-x5ow.site>

On Thu, Jun 29, 2017@10:32:28AM +0200, Johannes Thumshirn wrote:
> On Thu, Jun 29, 2017@08:44:04AM +0300, Sagi Grimberg wrote:
> > I agree with the latter, should we also move nvme.h to
> > uapi?
> 
> That was my first reaction as well. I'm all for it.

Absolutely not.  It's not a userspace API/ABI.  It's an internal header
that we want to be able to refactor if needed, e.g. if NVMe splits or
renames fields, or adds unions, etc.  It just happens that nvme-cli
needs the same defintions.

  reply	other threads:[~2017-06-29 13:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28 23:11 nvme defintions not used in the kernel Christoph Hellwig
2017-06-28 23:13 ` Jens Axboe
2017-06-29  5:44 ` Sagi Grimberg
2017-06-29  8:32   ` Johannes Thumshirn
2017-06-29 13:31     ` Christoph Hellwig [this message]
2017-06-29 14:25       ` Sagi Grimberg
2017-06-29 15:37 ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170629133159.GA10896@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox