From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 1/4] nvme-cli : add support for sanitize command.
Date: Thu, 29 Jun 2017 12:44:43 -0400 [thread overview]
Message-ID: <20170629164443.GF3110@localhost.localdomain> (raw)
In-Reply-To: <20170629021928.19389-2-chaitanya.kulkarni@hgst.com>
On Wed, Jun 28, 2017@07:19:25PM -0700, Chaitanya Kulkarni wrote:
> + const struct argconfig_commandline_options command_line_options[] = {
> + {"no_dealloc", 'd', "", CFG_NONE, &cfg.no_dealloc, no_argument, no_dealloc_desc},
Just a minor request, this tool uses '-' instead of '_' for compound
word long options, and I think keeping that consistency is a good thing.
Otherwise, this looks great.
next prev parent reply other threads:[~2017-06-29 16:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 2:19 nvme-cli : Sanitize and Sanitize Log command support Chaitanya Kulkarni
2017-06-29 2:19 ` [PATCH 1/4] nvme-cli : add support for sanitize command Chaitanya Kulkarni
2017-06-29 16:44 ` Keith Busch [this message]
2017-06-29 17:43 ` Keith Busch
2017-06-29 2:19 ` [PATCH 2/4] nvme-cli : add sanitize command documentation Chaitanya Kulkarni
2017-06-29 2:19 ` [PATCH 3/4] nvme-cli : add support for retrieving sanitize log Chaitanya Kulkarni
2017-06-29 2:19 ` [PATCH 4/4] nvme-cli : add sanitize-log command documentation Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629164443.GF3110@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox