From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme-rdma: stop keep_alive before nvme_uninit_ctrl
Date: Wed, 5 Jul 2017 21:08:11 +0200 [thread overview]
Message-ID: <20170705190811.GA7191@lst.de> (raw)
In-Reply-To: <9a40f029-9bd2-645a-d092-0656f279d94c@grimberg.me>
On Wed, Jul 05, 2017@10:04:31PM +0300, Sagi Grimberg wrote:
>>> +void nvme_stop_ctrl(struct nvme_ctrl *ctrl)
>>> +{
>>> + __nvme_stop_ctrl(ctrl);
>>> nvme_remove_namespaces(ctrl);
>>> +}
>>> +EXPORT_SYMBOL_GPL(nvme_stop_ctrl);
>>
>> And then this becomes nvme_remove_ctrl?
>
> Not a good idea as its not actually removing the controller...
>
> Maybe nvme_clear_ctrl?
Or just call both the new nvme_stop_ctrl and nvme_remove_namespaces
from each driver. It's a bit more code, but additional logic..
next prev parent reply other threads:[~2017-07-05 19:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 14:33 [PATCH] nvme-rdma: stop keep_alive before nvme_uninit_ctrl David Milburn
2017-06-29 14:45 ` Johannes Thumshirn
2017-06-29 15:44 ` David Milburn
2017-06-29 16:24 ` James Smart
2017-07-02 8:08 ` Sagi Grimberg
2017-07-04 9:57 ` Sagi Grimberg
2017-07-05 17:41 ` Christoph Hellwig
2017-07-05 19:04 ` Sagi Grimberg
2017-07-05 19:08 ` Christoph Hellwig [this message]
2017-07-05 19:18 ` Sagi Grimberg
2017-07-07 13:27 ` David Milburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705190811.GA7191@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox