Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH v3] nvme: split nvme_uninit_ctrl into stop and uninit
Date: Wed, 5 Jul 2017 18:41:51 -0400	[thread overview]
Message-ID: <20170705224150.GB24884@localhost.localdomain> (raw)
In-Reply-To: <20170705222502.GA24884@localhost.localdomain>

On Wed, Jul 05, 2017@06:25:02PM -0400, Keith Busch wrote:
> On Wed, Jul 05, 2017@11:34:17PM +0300, Sagi Grimberg wrote:
> > Usually before we teardown the controller we want to:
> > 1. complete/cancel any ctrl inflight works
> > 2. remove ctrl namespaces (only for removal though, resets
> >    shouldn't remove any namespaces).
> > 
> > but we do not want to destroy the controller device as
> > we might use it for logging during the teardown stage.
> > 
> > This patch adds nvme_start_ctrl() which queues inflight
> > controller works (aen, ns scan, queue start and keep-alive
> > if kato is set) and nvme_stop_ctrl() which cancels the works
> > namespace removal is left to the callers to handle.
> > 
> > Move nvme_uninit_ctrl after we are done with the
> > controller device.
> > 
> > Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
> 
> This looks good to me.
> 
> Reviewed-by: Keith Busch <keith.busch at intel.com>

Ah, it doesn't merge with your earlier patch, "nvme: move queue_count to
the nvme_ctrl". That 8-patch series the conflict came from looks good too,
so let's rebase this one on top of that.

  reply	other threads:[~2017-07-05 22:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 20:34 [PATCH v3] nvme: split nvme_uninit_ctrl into stop and uninit Sagi Grimberg
2017-07-05 22:25 ` Keith Busch
2017-07-05 22:41   ` Keith Busch [this message]
2017-07-05 23:02     ` Christoph Hellwig
2017-07-06  6:41     ` Sagi Grimberg
2017-07-06  6:53       ` Sagi Grimberg
2017-07-05 23:03 ` Christoph Hellwig
2017-07-06  7:12 ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170705224150.GB24884@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox