From: ming.lei@redhat.com (Ming Lei)
Subject: [PATCH v3 4/8] nvme-pci: quiesce/unquiesce admin_q instead of start/stop its hw queues
Date: Thu, 6 Jul 2017 06:50:54 +0800 [thread overview]
Message-ID: <20170705225053.GC2332@ming.t460p> (raw)
In-Reply-To: <1499274037-17438-5-git-send-email-sagi@grimberg.me>
On Wed, Jul 05, 2017@08:00:33PM +0300, Sagi Grimberg wrote:
> unlike blk_mq_stop_hw_queues and blk_mq_start_stopped_hw_queues
> quiescing/unquiescing respects the submission path rcu grace.
>
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
> ---
> drivers/nvme/host/pci.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index eb729ff70e7d..d9c0010a9bbc 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -1125,7 +1125,7 @@ static int nvme_suspend_queue(struct nvme_queue *nvmeq)
> spin_unlock_irq(&nvmeq->q_lock);
>
> if (!nvmeq->qid && nvmeq->dev->ctrl.admin_q)
> - blk_mq_stop_hw_queues(nvmeq->dev->ctrl.admin_q);
> + blk_mq_quiesce_queue(nvmeq->dev->ctrl.admin_q);
>
> pci_free_irq(to_pci_dev(nvmeq->dev->dev), vector, nvmeq);
>
> @@ -1315,7 +1315,7 @@ static void nvme_dev_remove_admin(struct nvme_dev *dev)
> * user requests may be waiting on a stopped queue. Start the
> * queue to flush these to completion.
> */
> - blk_mq_start_stopped_hw_queues(dev->ctrl.admin_q, true);
> + blk_mq_unquiesce_queue(dev->ctrl.admin_q);
> blk_cleanup_queue(dev->ctrl.admin_q);
> blk_mq_free_tag_set(&dev->admin_tagset);
> }
> @@ -1352,7 +1352,7 @@ static int nvme_alloc_admin_tags(struct nvme_dev *dev)
> return -ENODEV;
> }
> } else
> - blk_mq_start_stopped_hw_queues(dev->ctrl.admin_q, true);
> + blk_mq_unquiesce_queue(dev->ctrl.admin_q);
>
> return 0;
> }
> --
> 2.7.4
>
Reviewed-by: Ming Lei <ming.lei at redhat.com>
--
Ming
next prev parent reply other threads:[~2017-07-05 22:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 17:00 [PATCH v3 0/8] correct quiescing in several block drivers Sagi Grimberg
2017-07-05 17:00 ` [PATCH v3 1/8] nvme-rdma: quiesce/unquiesce admin_q instead of start/stop its hw queues Sagi Grimberg
2017-07-05 22:44 ` Ming Lei
2017-07-05 17:00 ` [PATCH v3 2/8] nvme-fc: " Sagi Grimberg
2017-07-05 22:49 ` Ming Lei
2017-07-05 17:00 ` [PATCH v3 3/8] nvme-loop: " Sagi Grimberg
2017-07-05 17:00 ` [PATCH v3 4/8] nvme-pci: " Sagi Grimberg
2017-07-05 22:50 ` Ming Lei [this message]
2017-07-05 17:00 ` [PATCH v3 5/8] nvme: kick requeue list when requeueing a request instead of when starting the queues Sagi Grimberg
2017-07-05 22:58 ` Ming Lei
2017-07-05 23:06 ` Christoph Hellwig
2017-07-05 23:23 ` Ming Lei
2017-07-05 17:00 ` [PATCH v3 6/8] nbd: quiesce request queues to make sure no submissions are inflight Sagi Grimberg
2017-07-05 18:08 ` Josef Bacik
2017-07-05 17:00 ` [PATCH v3 7/8] mtip32xx: " Sagi Grimberg
2017-07-05 17:00 ` [PATCH v3 8/8] virtio_blk: quiesce/unquiesce live IO when entering PM states Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705225053.GC2332@ming.t460p \
--to=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox