From: leon@kernel.org (Leon Romanovsky)
Subject: [PATCH v2 1/3] RDMA/core: make ib_device.add method optional
Date: Thu, 6 Jul 2017 11:33:01 +0300 [thread overview]
Message-ID: <20170706083301.GS1528@mtr-leonro.local> (raw)
In-Reply-To: <14303999-2479-653c-719f-ac5a5b03fb33@grimberg.me>
On Thu, Jul 06, 2017@10:51:36AM +0300, Sagi Grimberg wrote:
> > ib_clients can indeed fill .add to NULL, but then they will not see
> > any device removal notifications. The reason is that that
> > ib_register_client and ib_register_device checked existence of .add
> > before adding the creating a corresponding client_data and adding
> > it to the list. Simple condition reverse fixes the issue.
> >
> > Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
> > Reviewed-by: Christoph Hellwig <hch at lst.de>
> > Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
>
> Any RDMA folks?
It looks right and two gentlemen above already reviewed it.
Thanks,
Reviewed-by: Leon Romanovsky <leonro at mellanox.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-nvme/attachments/20170706/eeb4cec0/attachment.sig>
next prev parent reply other threads:[~2017-07-06 8:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-02 8:20 [PATCH v2 0/3] Allow ib_clients to nullify .add but still get .remove events reliably Sagi Grimberg
2017-07-02 8:20 ` [PATCH v2 1/3] RDMA/core: make ib_device.add method optional Sagi Grimberg
2017-07-06 7:51 ` Sagi Grimberg
2017-07-06 8:33 ` Leon Romanovsky [this message]
2017-07-06 8:38 ` Sagi Grimberg
2017-07-02 8:20 ` [PATCH v2 2/3] nvme-rdma: remove redundant empty device add callout Sagi Grimberg
2017-07-02 8:20 ` [PATCH v2 3/3] nvmet-rdma: " Sagi Grimberg
2017-07-02 9:14 ` [PATCH v2 0/3] Allow ib_clients to nullify .add but still get .remove events reliably Max Gurtovoy
2017-08-18 14:46 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706083301.GS1528@mtr-leonro.local \
--to=leon@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox