Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: jsmart2021@gmail.com (James Smart)
Subject: [PATCH 0/2] nvme-fc: Create Association corrections
Date: Fri,  7 Jul 2017 18:08:24 -0700	[thread overview]
Message-ID: <20170708010826.12448-1-jsmart2021@gmail.com> (raw)

The FC-NVME spec changed between 1.14 and 1.15 and will again in 1.16
to adjust the Create Association LS. The main change was to reduce
the HostID field from 64bytes to 16bytes. This change was picked up in
a linux by checkin in march. However, the 1.15 spec added pad that the
checkin didn't have and added additional pad it shouldn't have, causing
it to exceed the desired 1Kbytes max payload size for FC-NVME LS's.
1.16 will revise the pad such that the overall LS is 1024 bytes in length.

This patch updates the headers for the spec mod and also modifies the
target such that it will accept a variable amount of pad. This allows
older initiators to still connect.


James Smart (2):
  nvme_fc/nvmet_fc: revise Create Association descriptor length
  nvmet_fc: Accept variable pad lengths on Create Association LS

 drivers/nvme/target/fc.c | 20 +++++++++++++-------
 include/linux/nvme-fc.h  | 23 ++++++++++++++++++++++-
 2 files changed, 35 insertions(+), 8 deletions(-)

-- 
2.11.0

             reply	other threads:[~2017-07-08  1:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-08  1:08 James Smart [this message]
2017-07-08  1:08 ` [PATCH 1/2] nvme_fc/nvmet_fc: revise Create Association descriptor length James Smart
2017-07-10  5:45   ` Sagi Grimberg
2017-07-08  1:08 ` [PATCH 2/2] nvmet_fc: Accept variable pad lengths on Create Association LS James Smart
2017-07-10  5:45   ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170708010826.12448-1-jsmart2021@gmail.com \
    --to=jsmart2021@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox