From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 2/7] nvme/fc: Fix admin queue depth setup
Date: Mon, 10 Jul 2017 18:57:30 -0400 [thread overview]
Message-ID: <20170710225730.GB13671@localhost.localdomain> (raw)
In-Reply-To: <aef1f200-336f-fdf4-36bc-fe13bfd67474@grimberg.me>
On Mon, Jul 10, 2017@08:59:02AM +0300, Sagi Grimberg wrote:
> > The NVME_FC_AQ_BLKMQ_DEPTH is one less than what we actually want the
> > admin queue's depth to be since it subtracts the AEN entry.
> >
> > We also need to subtract 1 from the blk-mq depth to always leave an
> > empty queue entry, and to not collide command id with the AEN request.
> >
> > Signed-off-by: Keith Busch <keith.busch at intel.com>
>
> nvme-loop needs the same patch.
Yeah, it looks like it does, though it's inadvertently fixed in patch
4. In truth, patch 4 makes this one unnecessary for fc too, but I didn't
want to change the q-depth and centralize its definition in a single
patch. I'll spin a new version with the loop fix in the series, as well
as Christoph's suggestions.
next prev parent reply other threads:[~2017-07-10 22:57 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 16:22 [PATCH 0/7] NVMe Async Event Notification updates Keith Busch
2017-07-07 16:22 ` [PATCH 1/7] nvme/fc: There is only one AEN request Keith Busch
2017-07-10 23:12 ` James Smart
2017-07-07 16:22 ` [PATCH 2/7] nvme/fc: Fix admin queue depth setup Keith Busch
2017-07-10 5:59 ` Sagi Grimberg
2017-07-10 22:57 ` Keith Busch [this message]
2017-07-10 23:40 ` James Smart
2017-07-10 23:49 ` James Smart
2017-07-07 16:22 ` [PATCH 3/7] nvme/fc: remove unused "queue_size" field Keith Busch
2017-07-10 6:00 ` Sagi Grimberg
2017-07-10 23:44 ` James Smart
2017-07-07 16:22 ` [PATCH 4/7] nvme: Centralize blk-mq tag and AEN counts Keith Busch
2017-07-10 6:01 ` Sagi Grimberg
2017-07-10 23:51 ` James Smart
2017-07-07 16:22 ` [PATCH 5/7] nvme: Only one AEN request Keith Busch
2017-07-10 6:06 ` Sagi Grimberg
2017-07-10 23:53 ` James Smart
2017-07-07 16:23 ` [PATCH 6/7] nvme: Unexport starting async event work Keith Busch
2017-07-07 18:11 ` Christoph Hellwig
2017-07-07 19:54 ` Keith Busch
2017-07-07 16:23 ` [PATCH 7/7] nvme: Send change uevent when AEN completes Keith Busch
2017-07-07 18:14 ` Christoph Hellwig
2017-07-13 21:29 ` Keith Busch
2017-07-14 12:50 ` Guilherme G. Piccoli
2017-07-14 12:54 ` Christoph Hellwig
2017-07-14 12:53 ` Christoph Hellwig
2017-07-14 15:16 ` Keith Busch
2017-07-15 8:42 ` Christoph Hellwig
2017-07-17 15:22 ` Keith Busch
2017-08-01 11:59 ` Guan Junxiong
2017-07-10 10:17 ` Zou Ming
2017-07-10 17:38 ` Keith Busch
2017-07-10 23:57 ` James Smart
2017-07-11 14:43 ` Keith Busch
2017-07-11 17:14 ` James Smart
2017-07-13 16:09 ` Keith Busch
2017-07-07 18:09 ` [PATCH 0/7] NVMe Async Event Notification updates Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710225730.GB13671@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox