From: jthumshirn@suse.de (Johannes Thumshirn)
Subject: [PATCH] nvme: add wrapper for nvme ctrl register r/w
Date: Wed, 12 Jul 2017 14:01:52 +0200 [thread overview]
Message-ID: <20170712120152.GD4115@linux-x5ow.site> (raw)
In-Reply-To: <20170712115547.GA11085@lst.de>
On Wed, Jul 12, 2017@01:55:47PM +0200, Christoph Hellwig wrote:
> Mostly because it's a little shorter and we're only going to get
> more and more of these calls. In the end I don't feel strongly
> and we can just skip the patch for now and reconsider it once
> we have more register read/write calls.
I'm in favour of the patch as well. It hides the transport specific
implementation details quite good.
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-07-12 12:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 17:26 [PATCH] nvme: add wrapper for nvme ctrl register r/w weiping zhang
2017-07-12 7:20 ` Christoph Hellwig
2017-07-12 10:34 ` Sagi Grimberg
2017-07-12 11:55 ` Christoph Hellwig
2017-07-12 12:01 ` Johannes Thumshirn [this message]
2017-07-12 13:25 ` weiping zhang
2017-07-14 9:57 ` weiping zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170712120152.GD4115@linux-x5ow.site \
--to=jthumshirn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox