From: hch@lst.de (Christoph Hellwig)
Subject: [RFC] nvme: Fabrics should use the fctype field for data direction
Date: Thu, 13 Jul 2017 09:27:55 +0200 [thread overview]
Message-ID: <20170713072755.GA12984@lst.de> (raw)
In-Reply-To: <20170712165819.5326-1-jonathan.derrick@intel.com>
Interesting. I wonder how things ever worked without this..
But the Fabrics multiplexer is a bidi command, so nvme_is_write
will always return true currently.
On the host side it only matters for the passthrough ioctls,
which no one uses for the fabrics commands.
On the target side this means we always try to copy data in and
never out, strange.
So this looks good to me, but it'll need a little test run. As Sagi
said the loop driver is trivial to test, but one of us should also
run it though rdma testing.
next prev parent reply other threads:[~2017-07-13 7:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 16:58 [RFC] nvme: Fabrics should use the fctype field for data direction Jon Derrick
2017-07-13 6:55 ` Sagi Grimberg
2017-07-13 7:27 ` Christoph Hellwig [this message]
2017-07-13 7:59 ` Sagi Grimberg
2017-07-25 16:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713072755.GA12984@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox