From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v3] nvme: Add support for NVMe 1.3 Timestamp Feature
Date: Fri, 14 Jul 2017 09:12:11 +0200 [thread overview]
Message-ID: <20170714071211.GA17046@lst.de> (raw)
In-Reply-To: <20170713230350.2255-1-jonathan.derrick@intel.com>
> + status = nvme_set_features(ctrl, NVME_FEAT_TIMESTAMP,
> + 0, &ts, sizeof(ts), NULL);
> + if (status != 0)
If I'd want to nitpick, I'd say move as many as possible arguments to
the first line, and remove the superflous "!= 0":
status = nvme_set_features(ctrl, NVME_FEAT_TIMESTAMP, 0, &ts,
sizeof(ts), NULL);
if (status)
but that's something we can fix up when applying the patch.
Looks fine:
Reviewed-by: Christoph Hellwig <hch at lst.de>
prev parent reply other threads:[~2017-07-14 7:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 23:03 [PATCH v3] nvme: Add support for NVMe 1.3 Timestamp Feature Jon Derrick
2017-07-14 7:12 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170714071211.GA17046@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox