From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 3/3] nvme: wwid_show: copy hex string verbatim
Date: Sat, 15 Jul 2017 10:46:03 +0200 [thread overview]
Message-ID: <20170715084603.GC23189@lst.de> (raw)
In-Reply-To: <1500061257.4808.23.camel@suse.com>
On Fri, Jul 14, 2017@09:40:57PM +0200, Martin Wilck wrote:
> > True. Although that only really is a fix for buggy controllers,
> > and should not affect the PCIe controllers (for which a compliance
> > test for this exists, unfortunately that doesn't work for fabrics).
>
> Is that a NAK, or not?
That's an ACK for the null vs whitespace changes. The NAK
for this patch still stands.
> "We will"? People are (trying to) use NVMe with multipath today, and
> they use dm-multipath and multipathd for that. Maybe that'll change
> some day, but not too soon, I believe.
Who are these people and why aren't they on the nvme list? The
dm-mpath approach is fundamentally wrong for NVMe, and especially
NVMeOF - e.g. for NVMeOF we have the mandatory keep alive, so doing
any wonky path checking from userspace is just going to create
problems.
next prev parent reply other threads:[~2017-07-15 8:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 22:25 [PATCH 0/3] Improve readbility of NVME "wwid" attribute Martin Wilck
2017-07-13 22:25 ` [PATCH 1/3] nvmet: identify controller: improve standard compliance Martin Wilck
2017-07-14 7:54 ` Christoph Hellwig
2017-07-13 22:25 ` [PATCH 2/3] nvme: wwid_show: strip trailing 0-bytes Martin Wilck
2017-07-14 7:54 ` Christoph Hellwig
2017-07-13 22:25 ` [PATCH 3/3] nvme: wwid_show: copy hex string verbatim Martin Wilck
2017-07-14 7:54 ` Christoph Hellwig
2017-07-14 9:58 ` Martin Wilck
2017-07-14 12:30 ` Christoph Hellwig
2017-07-14 19:40 ` Martin Wilck
2017-07-15 8:46 ` Christoph Hellwig [this message]
2017-07-17 6:12 ` Hannes Reinecke
2017-07-13 22:57 ` [PATCH 0/3] Improve readbility of NVME "wwid" attribute Keith Busch
2017-07-14 7:54 ` Martin Wilck
2017-07-14 7:57 ` Christoph Hellwig
2017-07-14 7:56 ` Christoph Hellwig
2017-07-14 9:41 ` Martin Wilck
2017-07-14 12:28 ` Christoph Hellwig
2017-07-14 7:53 ` Christoph Hellwig
2017-07-14 8:54 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170715084603.GC23189@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox