From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/1] nvme: fix CMB sysfs file removal in reset path
Date: Tue, 25 Jul 2017 17:56:30 +0200 [thread overview]
Message-ID: <20170725155630.GA25693@lst.de> (raw)
In-Reply-To: <1500991116-8227-1-git-send-email-maxg@mellanox.com>
On Tue, Jul 25, 2017@04:58:36PM +0300, Max Gurtovoy wrote:
> Currently we create the sysfs entry even if we fail mapping
> it. In that case, the unmapping will not remove the sysfs created
> file.
>
> Fixes: f63572dff ("nvme: unmap CMB and remove sysfs file in reset path")
This looks correct, but I wonder if the better plan would be to only
add the sysfs file if we have a working CMB?
Also the comment about the auto-removal above the call to
sysfs_add_file_to_group for dev_attr_cmb looks wrong to me, that
might be worth fixing up as well.
next prev parent reply other threads:[~2017-07-25 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 13:58 [PATCH 1/1] nvme: fix CMB sysfs file removal in reset path Max Gurtovoy
2017-07-25 15:56 ` Christoph Hellwig [this message]
2017-07-25 17:13 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725155630.GA25693@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox