From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@infradead.org (Christoph Hellwig) Date: Thu, 10 Aug 2017 02:09:58 -0700 Subject: [PATCH] nvme-cli: fix connecting failure due to invalid uuid format of hostid In-Reply-To: <1501767496-14144-1-git-send-email-guanjunxiong@huawei.com> References: <1501767496-14144-1-git-send-email-guanjunxiong@huawei.com> Message-ID: <20170810090958.GA3880@infradead.org> On Thu, Aug 03, 2017@09:38:16PM +0800, Guan Junxiong wrote: > When we connect or discover a target with --hostid option via the > /etc/nvme/hostid file, we fails this operation because the hostid > is only 35 not 36 bytes which doesn't pass the uuid checking in the > kernel.The last character is overridden with null bytes because fgets > reads at most one less than sizeof of buffer characters. > > Signed-off-by: Guan Junxiong Looks good, Reviewed-by: Christoph Hellwig