From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme-cli: fix connecting failure due to invalid uuid format of hostid
Date: Thu, 10 Aug 2017 13:11:50 -0400 [thread overview]
Message-ID: <20170810171150.GF14634@localhost.localdomain> (raw)
In-Reply-To: <20170810090958.GA3880@infradead.org>
On Thu, Aug 10, 2017@02:09:58AM -0700, Christoph Hellwig wrote:
> On Thu, Aug 03, 2017@09:38:16PM +0800, Guan Junxiong wrote:
> > When we connect or discover a target with --hostid option via the
> > /etc/nvme/hostid file, we fails this operation because the hostid
> > is only 35 not 36 bytes which doesn't pass the uuid checking in the
> > kernel.The last character is overridden with null bytes because fgets
> > reads at most one less than sizeof of buffer characters.
> >
> > Signed-off-by: Guan Junxiong <guanjunxiong at huawei.com>
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
I meant to reply to this one instead of the nvme_fc patch. This one to
nvme-cli is applied.
prev parent reply other threads:[~2017-08-10 17:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 13:38 [PATCH] nvme-cli: fix connecting failure due to invalid uuid format of hostid Guan Junxiong
2017-08-10 9:09 ` Christoph Hellwig
2017-08-10 17:11 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810171150.GF14634@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox