From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme/pci: Print invalid SGL only once
Date: Fri, 15 Sep 2017 16:55:53 +0200 [thread overview]
Message-ID: <20170915145553.GA1147@lst.de> (raw)
In-Reply-To: <1505415974-13489-1-git-send-email-keith.busch@intel.com>
On Thu, Sep 14, 2017@03:06:14PM -0400, Keith Busch wrote:
> The WARN_ONCE macro returns true if the condition is true, not if the
> warn was raised, so we're printing the scatter list every time it's
> invalid. This is excessive and makes debugging harder, so this patch
> prints it just once.
Please use the printk_ratelimited() helper instead.
next prev parent reply other threads:[~2017-09-15 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 19:06 [PATCH] nvme/pci: Print invalid SGL only once Keith Busch
2017-09-15 7:36 ` Johannes Thumshirn
2017-09-15 14:55 ` Christoph Hellwig [this message]
2017-09-15 15:17 ` Keith Busch
2017-09-15 15:44 ` Keith Busch
2017-09-15 15:42 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915145553.GA1147@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox