From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 5/6] nvme: Export subsystems to /sys/class/nvme-subsys
Date: Mon, 2 Oct 2017 10:53:18 -0600 [thread overview]
Message-ID: <20171002165317.GT8463@localhost.localdomain> (raw)
In-Reply-To: <20171002161808.GD11048@lst.de>
On Mon, Oct 02, 2017@06:18:08PM +0200, Christoph Hellwig wrote:
> On Mon, Oct 02, 2017@03:55:58PM +0200, Hannes Reinecke wrote:
> > Create a class for each subsystem to create a 'device' link
> > for each subsystem device.
>
> I thought about this as it seems useful. The only downside is that
> iff we run into subsystems with duplicate NQNs (or fake NQNs using
> MN/SN) we are in deep trouble once this is exposed in sysfs.
>
> Keith was the one most concerned about that, so I'd like him to
> chime in.
The driver will unbind from the controller if it detects an unsupported
duplicate nvme subsystem. The same logic will prevent duplciate sysfs
entries in this patch, so I think we're okay from that standpoint.
My concern was the user can't query or fix the controller that has the
duplicate subsystem name since we unbind from it. Unbinding is probably
the right thing to do, though, so the confused subsystem can be fixed
when the user isolates it from the others.
BTW, I just notice nvme_init_subsystem needs call nvme_put_subsystem in
the invalid duplicate subnqn case.
next prev parent reply other threads:[~2017-10-02 16:53 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 13:55 [PATCH 0/6] nvme: sanitize multipathing Hannes Reinecke
2017-10-02 13:55 ` [PATCH 1/6] nvme: display 'CMIC' controller attribute Hannes Reinecke
2017-10-02 16:15 ` Christoph Hellwig
2017-10-02 13:55 ` [PATCH 2/6] nvme: use 'nvmsXnZ' instead of 'nvm-subXnZ' Hannes Reinecke
2017-10-02 16:16 ` Christoph Hellwig
2017-10-02 16:20 ` Keith Busch
2017-10-11 14:32 ` Guan Junxiong
2017-10-02 13:55 ` [PATCH 3/6] nvme: claim block devices Hannes Reinecke
2017-10-02 16:42 ` Christoph Hellwig
2017-10-03 10:08 ` Hannes Reinecke
2017-10-03 11:55 ` Christoph Hellwig
2017-10-04 5:42 ` Hannes Reinecke
2017-10-04 6:15 ` Christoph Hellwig
2017-10-04 6:33 ` Hannes Reinecke
2017-10-04 7:13 ` Christoph Hellwig
2017-10-04 7:26 ` Hannes Reinecke
2017-10-05 1:08 ` Martin K. Petersen
2017-10-05 6:51 ` Johannes Thumshirn
2017-10-05 14:05 ` Keith Busch
2017-10-05 14:39 ` Hannes Reinecke
2017-10-05 14:47 ` Christoph Hellwig
2017-10-02 13:55 ` [PATCH 4/6] nvme: display 'NMIC' namespace attribute Hannes Reinecke
2017-10-02 16:16 ` Christoph Hellwig
2017-10-03 10:00 ` Hannes Reinecke
2017-10-03 11:49 ` Christoph Hellwig
2017-10-03 16:01 ` Hannes Reinecke
2017-10-02 13:55 ` [PATCH 5/6] nvme: Export subsystems to /sys/class/nvme-subsys Hannes Reinecke
2017-10-02 16:18 ` Christoph Hellwig
2017-10-02 16:53 ` Keith Busch [this message]
2017-10-02 16:56 ` Christoph Hellwig
2017-10-02 17:15 ` Keith Busch
2017-10-02 13:55 ` [PATCH 6/6] nvme: ignore retries for multipath devices Hannes Reinecke
2017-10-02 16:22 ` Christoph Hellwig
2017-10-03 10:02 ` Hannes Reinecke
2017-10-03 11:53 ` Christoph Hellwig
2017-10-02 14:35 ` [PATCH] nvme: reset retires after path failover Johannes Thumshirn
2017-10-02 14:43 ` Keith Busch
2017-10-02 15:08 ` Hannes Reinecke
2017-10-02 14:45 ` Johannes Thumshirn
2017-10-02 16:25 ` Christoph Hellwig
2017-10-02 14:46 ` Johannes Thumshirn
2017-10-02 16:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002165317.GT8463@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).