* [PATCH] nvmet: bump NVMET_NR_QUEUES to 128
@ 2017-09-11 23:14 James Smart
2017-09-12 11:59 ` Max Gurtovoy
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: James Smart @ 2017-09-11 23:14 UTC (permalink / raw)
Raise the max number of IO queues to 128. There are several hosts with
more than 64 cpus/threads.
Signed-off-by: James Smart <james.smart at broadcom.com>
---
drivers/nvme/target/nvmet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
index 7b8e20adf760..e342f02845c1 100644
--- a/drivers/nvme/target/nvmet.h
+++ b/drivers/nvme/target/nvmet.h
@@ -314,7 +314,7 @@ u16 nvmet_copy_from_sgl(struct nvmet_req *req, off_t off, void *buf,
u32 nvmet_get_log_page_len(struct nvme_command *cmd);
#define NVMET_QUEUE_SIZE 1024
-#define NVMET_NR_QUEUES 64
+#define NVMET_NR_QUEUES 128
#define NVMET_MAX_CMD NVMET_QUEUE_SIZE
#define NVMET_KAS 10
#define NVMET_DISC_KATO 120
--
2.13.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] nvmet: bump NVMET_NR_QUEUES to 128
2017-09-11 23:14 [PATCH] nvmet: bump NVMET_NR_QUEUES to 128 James Smart
@ 2017-09-12 11:59 ` Max Gurtovoy
2017-09-14 17:03 ` Christoph Hellwig
2017-10-04 7:46 ` Christoph Hellwig
2 siblings, 0 replies; 6+ messages in thread
From: Max Gurtovoy @ 2017-09-12 11:59 UTC (permalink / raw)
On 9/12/2017 2:14 AM, James Smart wrote:
> Raise the max number of IO queues to 128. There are several hosts with
> more than 64 cpus/threads.
>
> Signed-off-by: James Smart <james.smart at broadcom.com>
> ---
> drivers/nvme/target/nvmet.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
I guess it's about time as more and more systems use > 64 cpus,
Reviewed-by: Max Gurtovoy <maxg at mellanox.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] nvmet: bump NVMET_NR_QUEUES to 128
2017-09-11 23:14 [PATCH] nvmet: bump NVMET_NR_QUEUES to 128 James Smart
2017-09-12 11:59 ` Max Gurtovoy
@ 2017-09-14 17:03 ` Christoph Hellwig
2017-09-14 18:36 ` James Smart
2017-10-04 7:46 ` Christoph Hellwig
2 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2017-09-14 17:03 UTC (permalink / raw)
This looks ok as a quick check, but any chance you could send
a patch to make this configurable through configfs? Preferably
also for the max queue size.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] nvmet: bump NVMET_NR_QUEUES to 128
2017-09-14 17:03 ` Christoph Hellwig
@ 2017-09-14 18:36 ` James Smart
2017-10-05 7:52 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: James Smart @ 2017-09-14 18:36 UTC (permalink / raw)
On 9/14/2017 10:03 AM, Christoph Hellwig wrote:
> This looks ok as a quick check, but any chance you could send
> a patch to make this configurable through configfs? Preferably
> also for the max queue size.
Yep - I'll put one together
-- james
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] nvmet: bump NVMET_NR_QUEUES to 128
2017-09-11 23:14 [PATCH] nvmet: bump NVMET_NR_QUEUES to 128 James Smart
2017-09-12 11:59 ` Max Gurtovoy
2017-09-14 17:03 ` Christoph Hellwig
@ 2017-10-04 7:46 ` Christoph Hellwig
2 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2017-10-04 7:46 UTC (permalink / raw)
Thanks, applied to nvme-4.15.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] nvmet: bump NVMET_NR_QUEUES to 128
2017-09-14 18:36 ` James Smart
@ 2017-10-05 7:52 ` Christoph Hellwig
0 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2017-10-05 7:52 UTC (permalink / raw)
On Thu, Sep 14, 2017@11:36:48AM -0700, James Smart wrote:
> On 9/14/2017 10:03 AM, Christoph Hellwig wrote:
> > This looks ok as a quick check, but any chance you could send
> > a patch to make this configurable through configfs? Preferably
> > also for the max queue size.
>
> Yep - I'll put one together
Did you get a chance to look at that?
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-05 7:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-11 23:14 [PATCH] nvmet: bump NVMET_NR_QUEUES to 128 James Smart
2017-09-12 11:59 ` Max Gurtovoy
2017-09-14 17:03 ` Christoph Hellwig
2017-09-14 18:36 ` James Smart
2017-10-05 7:52 ` Christoph Hellwig
2017-10-04 7:46 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).