linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH V4 1/2] nvme: add SGL controller capability constant
Date: Wed, 4 Oct 2017 14:04:00 -0600	[thread overview]
Message-ID: <20171004200359.GA2384@localhost.localdomain> (raw)
In-Reply-To: <1507058666-15298-2-git-send-email-ckulkarnilinux@gmail.com>

On Tue, Oct 03, 2017@12:24:25PM -0700, Chaitanya Kulkarni wrote:
> From: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index 9310ce77..22bbcfb 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -466,6 +466,8 @@ enum nvme_opcode {
>  	nvme_cmd_resv_release	= 0x15,
>  };
>  
> +#define NVME_CTRL_SUPP_SGL     0x1
> +

I don't think this needs to be its own patch.

This should be in enum along with all the other NVME_CTRL_* identify
controller constants.

SGLs would also be supported if the value is 2 as well, right?

  reply	other threads:[~2017-10-04 20:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-03 19:24 [PATCH V4] nvme-pci: add SGL support Chaitanya Kulkarni
2017-10-03 19:24 ` [PATCH V4 1/2] nvme: add SGL controller capability constant Chaitanya Kulkarni
2017-10-04 20:04   ` Keith Busch [this message]
2017-10-03 19:24 ` [PATCH V4 2/2] nvme-pci: add SGL support Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171004200359.GA2384@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).