From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH V6] nvme-pci: add SGL support
Date: Mon, 9 Oct 2017 12:03:00 -0600 [thread overview]
Message-ID: <20171009180300.GD19329@localhost.localdomain> (raw)
In-Reply-To: <1507232903-9532-2-git-send-email-ckulkarnilinux@gmail.com>
On Thu, Oct 05, 2017@12:48:23PM -0700, Chaitanya Kulkarni wrote:
> + iod_list(req)[0] = sg_list;
> + iod->first_dma = sgl_dma;
> +
> + if (entries <= SGES_PER_PAGE) {
> + nvme_pci_sgl_set_last_seg(&cmd->dptr.sgl, sgl_dma, entries);
> +
> + for (i = 0; i < entries; i++) {
> + nvme_pci_sgl_set_data(&sg_list[i], sg);
> + length -= sg_dma_len(sg);
> + sg = sg_next(sg);
> + }
> +
> + WARN_ON(length > 0);
> + return BLK_STS_OK;
> + }
> +
> + nvme_pci_sgl_set_seg(&cmd->dptr.sgl, sgl_dma);
> +
> + do {
> + if (i == SGES_PER_PAGE) {
> + struct nvme_sgl_desc *old_sg_desc = sg_list;
> + struct nvme_sgl_desc *link = &old_sg_desc[i - 1];
> +
> + sg_list = dma_pool_alloc(pool, GFP_ATOMIC, &sgl_dma);
> + if (!sg_list)
> + return BLK_STS_RESOURCE;
> +
> + i = 0;
> + iod_list(req)[iod->npages++] = sg_list;
> + sg_list[i++] = *link;
> +
> + if (entries < SGES_PER_PAGE)
> + nvme_pci_sgl_set_last_seg(link, sgl_dma, entries);
> + else
> + nvme_pci_sgl_set_seg(link, sgl_dma);
> + }
> +
> + nvme_pci_sgl_set_data(&sg_list[i], sg);
> +
> + length -= sg_dma_len(sg);
> + sg = sg_next(sg);
> + entries--;
> + } while (length > 0);
There's two loops here doing essentially the same thing, but I don't
think the single segment needs to have a special case.
next prev parent reply other threads:[~2017-10-09 18:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 19:48 [PATCH V6] nvme-pci: add SGL support Chaitanya Kulkarni
2017-10-05 19:48 ` Chaitanya Kulkarni
2017-10-08 9:16 ` Max Gurtovoy
2017-10-08 9:57 ` [Suspected-Phishing]Re: " Max Gurtovoy
2017-10-13 3:19 ` chaitany kulkarni
2017-10-16 7:58 ` Christoph Hellwig
2017-10-09 18:03 ` Keith Busch [this message]
2017-10-16 7:59 ` Christoph Hellwig
2017-10-11 11:01 ` Sagi Grimberg
2017-10-13 3:35 ` chaitany kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009180300.GD19329@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).