[PATCH] nvme/target: Change max_nsid in subsystem due to ns_disable if needed

[PATCH] nvme/target: Change max_nsid in subsystem due to ns_disable if needed

[roys]

From: Roy Shterman <roys@lightbitslabs.com>

In case we disable namespaces which has the nsid like
subsystem max_nsid we need to search for the next largest nsid
in this subsystem. If the subsystem don't has more namespaces
we set it to 0, else we take nsid from the last namespace in
namespaces list because the list is sorted while inserting.

Signed-off-by: Roy Shterman <roys at lightbitslabs.com>
---
 drivers/nvme/target/core.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
index eb9399a..e996972 100644
--- a/drivers/nvme/target/core.c
+++ b/drivers/nvme/target/core.c
@@ -334,6 +334,17 @@ void nvmet_ns_disable(struct nvmet_ns *ns)
 
 	ns->enabled = false;
 	list_del_rcu(&ns->dev_link);
+
+	if (ns->nsid == subsys->max_nsid) {
+		if (list_empty(&subsys->namespaces)) {
+			subsys->max_nsid = 0;
+		} else {
+			struct nvmet_ns *ns = list_last_entry(&subsys->namespaces, struct nvmet_ns, entry);
+
+			subsys->max_nsid = ns->nsid;
+		}
+	}
+
 	mutex_unlock(&subsys->lock);
 
 	/*
-- 
2.7.4

[PATCH] nvme/target: Change max_nsid in subsystem due to ns_disable if needed

[Sagi Grimberg]

Looks good,

Reviewed-by: Sagi Grimberg <sagi at rimberg.me>

[PATCH] nvme/target: Change max_nsid in subsystem due to ns_disable if needed

[Max Gurtovoy]

On 10/10/2017 6:59 PM, roys@lightbitslabs.com wrote:
> From: Roy Shterman <roys at lightbitslabs.com>
> 
> In case we disable namespaces which has the nsid like
> subsystem max_nsid we need to search for the next largest nsid
> in this subsystem. If the subsystem don't has more namespaces
> we set it to 0, else we take nsid from the last namespace in
> namespaces list because the list is sorted while inserting.
> 
> Signed-off-by: Roy Shterman <roys at lightbitslabs.com>
> ---

Looks good,

Reviewed-by: Max Gurtovoy <maxg at mellanox.com>

[PATCH] nvme/target: Change max_nsid in subsystem due to ns_disable if needed

[Christoph Hellwig]

Looks good and a reasonable 4.14. candidate.

[PATCH] nvme/target: Change max_nsid in subsystem due to ns_disable if needed

[Christoph Hellwig]

Actually, this doesn't even compile..  the entry in ->namespaces
is dev_link, not entry.

If you resend please also fix the line > 80 chars, preferably
by adding a new helper that returns the new max_nsid value.