linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 4.14-rc] nvme-rdma: Fix error status return in tagset allocation failure
Date: Thu, 19 Oct 2017 17:04:07 +0200	[thread overview]
Message-ID: <20171019150407.GA24110@lst.de> (raw)
In-Reply-To: <94390d33-dc54-b8ae-ed9a-ba49c4f71ae0@grimberg.me>

On Thu, Oct 19, 2017@05:58:16PM +0300, Sagi Grimberg wrote:
>
>> Actually, let's skip the idea - I just noticed nvme_rdma_alloc_tagset does
>> way too many different things for the admin vs io taget.
>>
>> I'm fine with your original version, but once we refactor things in this
>> area I have a few ideas how to improve things.
>
> I have no doubt you do...

In the meantime can you write a more detailed changelog?  For a late
rc fix I'd really like to have a better description especially with
Linus hating us block and nvme people at the moment :)

      reply	other threads:[~2017-10-19 15:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-19  6:58 [PATCH 4.14-rc] nvme-rdma: Fix error status return in tagset allocation failure Sagi Grimberg
2017-10-19  8:49 ` Christoph Hellwig
2017-10-19  9:41   ` Sagi Grimberg
2017-10-19 10:20     ` Christoph Hellwig
2017-10-19 10:28       ` Sagi Grimberg
2017-10-19 13:55         ` Christoph Hellwig
2017-10-19 14:44           ` Sagi Grimberg
2017-10-19 14:49             ` Christoph Hellwig
2017-10-19 14:58               ` Sagi Grimberg
2017-10-19 15:04                 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171019150407.GA24110@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).