From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH V7] nvme-pci: add SGL support
Date: Thu, 19 Oct 2017 09:48:22 -0600 [thread overview]
Message-ID: <20171019154821.GD2768@localhost.localdomain> (raw)
In-Reply-To: <20171019102847.GA6828@infradead.org>
Yeah, I don't have any major concerns. I was hung up on the
tagset.cmd_size being smaller when SGL's are used, but it took me a
minute to determine that's okay as we were overallocating it before.
The criteria used to select sgl usage makes sense, so good to go on my
end.
Reviewed-by: Keith Busch <keith.busch at intel.com>
next prev parent reply other threads:[~2017-10-19 15:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 1:24 [PATCH V7] nvme-pci: add SGL support Chaitanya Kulkarni
2017-10-19 10:28 ` Christoph Hellwig
2017-10-19 10:31 ` Sagi Grimberg
2017-10-19 15:48 ` Keith Busch [this message]
2017-10-20 10:12 ` Christoph Hellwig
2017-10-20 14:37 ` Keith Busch
2017-10-20 10:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019154821.GD2768@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).