From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH V7] nvme-pci: add SGL support
Date: Fri, 20 Oct 2017 08:37:00 -0600 [thread overview]
Message-ID: <20171020143659.GA3493@localhost.localdomain> (raw)
In-Reply-To: <20171020101201.GA26703@infradead.org>
On Fri, Oct 20, 2017@03:12:01AM -0700, Christoph Hellwig wrote:
> On Thu, Oct 19, 2017@09:48:22AM -0600, Keith Busch wrote:
> > Yeah, I don't have any major concerns. I was hung up on the
> > tagset.cmd_size being smaller when SGL's are used, but it took me a
> > minute to determine that's okay as we were overallocating it before.
>
> How is it smaller? The code ensures we use the larger of the two
> calculations:
>
> dev->tagset.cmd_size = nvme_pci_cmd_size(dev, false);
> if ((dev->ctrl.sgls & ((1 << 0) | (1 << 1))) && sgl_threshold) {
> dev->tagset.cmd_size = max(dev->tagset.cmd_size,
> nvme_pci_cmd_size(dev, true));
> }
Oops, my mistake.
next prev parent reply other threads:[~2017-10-20 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 1:24 [PATCH V7] nvme-pci: add SGL support Chaitanya Kulkarni
2017-10-19 10:28 ` Christoph Hellwig
2017-10-19 10:31 ` Sagi Grimberg
2017-10-19 15:48 ` Keith Busch
2017-10-20 10:12 ` Christoph Hellwig
2017-10-20 14:37 ` Keith Busch [this message]
2017-10-20 10:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020143659.GA3493@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).