From: hch@lst.de (Christoph Hellwig)
Subject: [PATCHv2 5/5] nvme: Send uevent for unhandled AEN completions
Date: Sat, 21 Oct 2017 10:09:06 +0200 [thread overview]
Message-ID: <20171021080906.GE20906@lst.de> (raw)
In-Reply-To: <20171020223746.31287-1-keith.busch@intel.com>
On Fri, Oct 20, 2017@04:37:46PM -0600, Keith Busch wrote:
> This will give udev a chance to handle asynchronous event notification
> and clear the log to unmask future events of the same type. Since the
> core driver allows only one AEN request at a time, we can only have one
> possible oustanding uevent to send.
I don't want to encode that in the userspace ABI. With all kinds of
new AEN uses coming up we might as well want to go for multiple AERs
in the future.
> This implementation saves the last
> AEN result from the IRQ handler, and sends the uevent change notification
> when the AEN work is rescheduled.
>
> AEN events that the kernel handles directly will not create a uevent. Such
> events will stop being sent to the user as new handlers are added to
> the kernel.
I think we need an explicit whitelist of the ones we want to expose
to userspace. Otherwise we'll get all kinds of complaints later
that we'd take something away and break the ABI.
next prev parent reply other threads:[~2017-10-21 8:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 22:37 [PATCHv2 5/5] nvme: Send uevent for unhandled AEN completions Keith Busch
2017-10-21 8:09 ` Christoph Hellwig [this message]
2017-10-23 15:01 ` Keith Busch
2017-10-30 10:14 ` Guan Junxiong
2017-10-30 15:18 ` Keith Busch
-- strict thread matches above, loose matches on Subject: below --
2017-10-20 22:19 [PATCHv2 0/5] AEN and userspace updates Keith Busch
2017-10-20 22:19 ` [PATCHv2 5/5] nvme: Send uevent for unhandled AEN completions Keith Busch
2017-10-20 22:29 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171021080906.GE20906@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).