From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 12/17] nvme: check for a live controller in nvme_dev_open
Date: Mon, 23 Oct 2017 16:51:21 +0200 [thread overview]
Message-ID: <20171023145126.2471-13-hch@lst.de> (raw)
In-Reply-To: <20171023145126.2471-1-hch@lst.de>
This is a much more sensible check than just the admin queue.
Signed-off-by: Christoph Hellwig <hch at lst.de>
Reviewed-by: Sagi Grimberg <sagi at rimbeg.me>
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index a56a1e0432e7..df525ab42fcd 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1891,7 +1891,7 @@ static int nvme_dev_open(struct inode *inode, struct file *file)
struct nvme_ctrl *ctrl =
container_of(inode->i_cdev, struct nvme_ctrl, cdev);
- if (!ctrl->admin_q)
+ if (ctrl->state != NVME_CTRL_LIVE)
return -EWOULDBLOCK;
file->private_data = ctrl;
return 0;
--
2.14.2
next prev parent reply other threads:[~2017-10-23 14:51 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 14:51 nvme multipath support V5 Christoph Hellwig
2017-10-23 14:51 ` [PATCH 01/17] block: move REQ_NOWAIT Christoph Hellwig
2017-10-23 14:51 ` [PATCH 02/17] block: add REQ_DRV bit Christoph Hellwig
2017-10-23 14:51 ` [PATCH 03/17] block: provide a direct_make_request helper Christoph Hellwig
2017-10-24 7:05 ` Hannes Reinecke
2017-10-24 17:57 ` Javier González
2017-10-23 14:51 ` [PATCH 04/17] block: add a blk_steal_bios helper Christoph Hellwig
2017-10-24 7:07 ` Hannes Reinecke
2017-10-24 8:44 ` Max Gurtovoy
2017-10-28 6:13 ` Christoph Hellwig
2017-10-23 14:51 ` [PATCH 05/17] block: don't look at the struct device dev_t in disk_devt Christoph Hellwig
2017-10-24 7:08 ` Hannes Reinecke
2017-10-23 14:51 ` [PATCH 06/17] block: introduce GENHD_FL_HIDDEN Christoph Hellwig
2017-10-24 7:18 ` Hannes Reinecke
2017-10-28 6:15 ` Christoph Hellwig
2017-10-24 21:40 ` Mike Snitzer
2017-10-28 6:38 ` Christoph Hellwig
2017-10-28 7:20 ` Guan Junxiong
2017-10-28 7:42 ` Christoph Hellwig
2017-10-28 10:09 ` Guan Junxiong
2017-10-29 8:00 ` Anish Jhaveri
2017-10-29 8:57 ` Christoph Hellwig
2017-10-28 14:17 ` Mike Snitzer
2017-10-29 10:01 ` Hannes Reinecke
2017-10-30 4:09 ` Guan Junxiong
2017-10-23 14:51 ` [PATCH 07/17] block: add a poll_fn callback to struct request_queue Christoph Hellwig
2017-10-24 7:20 ` Hannes Reinecke
2017-10-23 14:51 ` [PATCH 08/17] nvme: use kref_get_unless_zero in nvme_find_get_ns Christoph Hellwig
2017-10-24 7:21 ` Hannes Reinecke
2017-10-23 14:51 ` [PATCH 09/17] nvme: simplify nvme_open Christoph Hellwig
2017-10-24 7:21 ` Hannes Reinecke
2017-10-23 14:51 ` [PATCH 10/17] nvme: switch controller refcounting to use struct device Christoph Hellwig
2017-10-24 7:23 ` Hannes Reinecke
2017-10-23 14:51 ` [PATCH 11/17] nvme: get rid of nvme_ctrl_list Christoph Hellwig
2017-10-24 7:24 ` Hannes Reinecke
2017-10-23 14:51 ` Christoph Hellwig [this message]
2017-10-24 7:25 ` [PATCH 12/17] nvme: check for a live controller in nvme_dev_open Hannes Reinecke
2017-10-23 14:51 ` [PATCH 13/17] nvme: track subsystems Christoph Hellwig
2017-10-24 7:33 ` Hannes Reinecke
2017-10-23 14:51 ` [PATCH 14/17] nvme: introduce a nvme_ns_ids structure Christoph Hellwig
2017-10-24 7:27 ` Hannes Reinecke
2017-10-23 14:51 ` [PATCH 15/17] nvme: track shared namespaces Christoph Hellwig
2017-10-24 7:34 ` Hannes Reinecke
2017-10-23 14:51 ` [PATCH 16/17] nvme: implement multipath access to nvme subsystems Christoph Hellwig
2017-10-23 15:32 ` Sagi Grimberg
2017-10-23 16:57 ` Christoph Hellwig
2017-10-23 17:43 ` Sagi Grimberg
2017-10-24 7:43 ` Hannes Reinecke
2017-10-28 6:32 ` Christoph Hellwig
2017-10-30 3:37 ` Guan Junxiong
2017-11-02 18:22 ` Christoph Hellwig
2017-10-23 14:51 ` [PATCH 17/17] nvme: also expose the namespace identification sysfs files for mpath nodes Christoph Hellwig
2017-10-24 7:45 ` Hannes Reinecke
2017-10-28 6:20 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2017-10-18 16:52 nvme multipath support V4 Christoph Hellwig
2017-10-18 16:52 ` [PATCH 12/17] nvme: check for a live controller in nvme_dev_open Christoph Hellwig
2017-10-19 7:18 ` Sagi Grimberg
2017-10-19 7:23 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023145126.2471-13-hch@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).