From: hch@lst.de (Christoph Hellwig)
Subject: controller deletion consolidation
Date: Sun, 29 Oct 2017 10:44:26 +0200 [thread overview]
Message-ID: <20171029084431.8702-1-hch@lst.de> (raw)
Hi all,
this series consolidates a lot of the boilerplate code in controller
deletion. I did this when applying the FC patches that finally made
it look exactly like RDMA.
This will probably conflict a bit with Sagis consolidation series, but
in the end should make it easier.
Two notes:
- do we need the cancellation of reset_work in FC? If so we probably
want it in RDMA and loop as well.
- should RDMA really queue delete_work manually in
nvme_rdma_reconnect_or_remove instead of going through the state
machine? That seems like a bug to me.
next reply other threads:[~2017-10-29 8:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 8:44 Christoph Hellwig [this message]
2017-10-29 8:44 ` [PATCH 1/5] nvme-fc: avoid workqueue flush stalls Christoph Hellwig
2017-10-29 8:44 ` [PATCH 2/5] nvme-fc: merge __nvme_fc_schedule_delete_work into __nvme_fc_del_ctrl Christoph Hellwig
2017-10-30 19:52 ` James Smart
2017-10-29 8:44 ` [PATCH 3/5] nvme: move controller deletion to common code Christoph Hellwig
2017-10-30 19:58 ` James Smart
2017-10-29 8:44 ` [PATCH 4/5] nvme-rdma: remove nvme_rdma_remove_ctrl Christoph Hellwig
2017-10-29 8:44 ` [PATCH 5/5] nvme: consolidate common code from ->reset_work Christoph Hellwig
2017-10-30 20:00 ` James Smart
2017-10-29 11:57 ` controller deletion consolidation Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171029084431.8702-1-hch@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).