linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme: fix and clarify the check for missing metadata
Date: Tue, 7 Nov 2017 09:35:12 -0700	[thread overview]
Message-ID: <20171107163511.GD29942@localhost.localdomain> (raw)
In-Reply-To: <20171107162734.4600-1-hch@lst.de>

On Tue, Nov 07, 2017@05:27:34PM +0100, Christoph Hellwig wrote:
> Update the check in nvme_setup_rw for missing metadata so that it is
> together with the other metadata handling, does not contain impossible
> to reach conditions and warns if we get an impossible requests for
> a (non-PI) metadata-enabled namespace when CONFIG_BLK_DEV_INTEGRITY
> is not set.
> 
> Also add a little helper that checks if a given metadata configuration
> contains protection information
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>

Looks good to me.

Reviewed-by: Keith Busch <keith.busch at intel.com>

      reply	other threads:[~2017-11-07 16:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07 16:27 [PATCH] nvme: fix and clarify the check for missing metadata Christoph Hellwig
2017-11-07 16:35 ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171107163511.GD29942@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).