From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 1/2] NVMe-CLI : WDC-Plugin Updated Smart Log Commands
Date: Wed, 8 Nov 2017 10:03:24 -0700 [thread overview]
Message-ID: <20171108170323.GB25017@localhost.localdomain> (raw)
In-Reply-To: <20171108164947.28987-1-jeff.lien@wdc.com>
On Wed, Nov 08, 2017@10:49:47AM -0600, jeffreyalien wrote:
> PLUGIN(NAME("wdc", "Western Digital vendor specific extensions"),
> COMMAND_LIST(
> - ENTRY("cap-diag", "WDC Capture-Diagnostics", wdc_cap_diag)
> - ENTRY("drive-log", "WDC Drive Log", wdc_drive_log)
> - ENTRY("get-crash-dump", "WDC Crash Dump", wdc_get_crash_dump)
> - ENTRY("id-ctrl", "WDC identify controller", wdc_id_ctrl)
> - ENTRY("purge", "WDC Purge", wdc_purge)
> - ENTRY("purge-monitor", "WDC Purge Monitor", wdc_purge_monitor)
> - ENTRY("smart-log-add", "WDC Additional Smart Log", wdc_smart_log_add)
> + ENTRY("cap-diag", " WDC Capture-Diagnostics", wdc_cap_diag)
> + ENTRY("drive-log", " WDC Drive Log", wdc_drive_log)
> + ENTRY("get-crash-dump", " WDC Crash Dump", wdc_get_crash_dump)
> + ENTRY("id-ctrl", " WDC identify controller", wdc_id_ctrl)
> + ENTRY("purge", " WDC Purge", wdc_purge)
> + ENTRY("purge-monitor", " WDC Purge Monitor", wdc_purge_monitor)
> + ENTRY("vs-smart-add-log", " WDC Additional Smart Log", wdc_smart_add_log)
> + ENTRY("vs-smart-add-log-c1", " WDC Additional Smart Log for C1 Log page", wdc_smart_add_log_c1)
> )
> );
I wasn't sure why you added so much whitespace for your descriptions until
I ran it. Maybe drop the "vs-" prefix since it's already vendor-specific
by virtue of being a vendor specific plugin? The alignment comes out
nicer that way.
next prev parent reply other threads:[~2017-11-08 17:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 16:49 [PATCH 1/2] NVMe-CLI : WDC-Plugin Updated Smart Log Commands jeffreyalien
2017-11-08 17:03 ` Keith Busch [this message]
2017-11-08 17:44 ` Jeffrey Lien
2017-11-13 21:24 ` FW: " Jeffrey Lien
2017-11-14 5:50 ` Christoph Hellwig
[not found] ` <CADL4p-p4eQ3_QDM5Vvn9Vn6NpD+UvGUGSx760tAZFiMf21oLxA@mail.gmail.com>
2017-11-15 11:35 ` Tony Yang
2017-11-15 15:14 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108170323.GB25017@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox