Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/1] nvme-rdma: Fix memory leak during queue allocation
Date: Thu, 9 Nov 2017 10:38:19 +0100	[thread overview]
Message-ID: <20171109093813.GA17515@lst.de> (raw)
In-Reply-To: <1510146032-25434-1-git-send-email-maxg@mellanox.com>

On Wed, Nov 08, 2017@03:00:32PM +0200, Max Gurtovoy wrote:
> In case nvme_rdma_wait_for_cm timeout expires before we get
> an established or rejected event (rdma_connect succeeded) from
> rdma_cm, we end up with leaking the ib resources for dedicated
> queue.
> This scenario can easily reproduced using traffic test during port
> toggling.
> 
> Signed-off-by: Max Gurtovoy <maxg at mellanox.com>

Looks fine. but a little comment on the special casing of
-ETIMEDOUT would be nice.

  reply	other threads:[~2017-11-09  9:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08 13:00 [PATCH 1/1] nvme-rdma: Fix memory leak during queue allocation Max Gurtovoy
2017-11-09  9:38 ` Christoph Hellwig [this message]
2017-11-09 11:02 ` Sagi Grimberg
2017-11-09 11:09   ` Max Gurtovoy
2017-11-09 11:40     ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171109093813.GA17515@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox