From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/5] nvme: track subsystems
Date: Thu, 9 Nov 2017 13:53:56 +0100 [thread overview]
Message-ID: <20171109125356.GB21795@lst.de> (raw)
In-Reply-To: <fbacd62b-4228-60cb-a382-9c88daadb336@grimberg.me>
On Thu, Nov 09, 2017@01:33:16PM +0200, Sagi Grimberg wrote:
> Any reason to do all this before we know if we found an existing subsystem?
We'd either have to do all the initialization including the memory
allocation and ida_simple_get under nvme_subsystems_lock, or search
the list first, then allocate, then search again.
Given that the not found case is vastly more common than the found
case that doesn't seem to be worth the tradeoff.
> Also can the enumeration become with "holes" because you
> acquire a subsystem ida temporarily and free it (and another subsystem
> just came in)? Not a big issue though...
It can, just like it can for the discovery controller in fabrics.
but so far that hasn't been an issue.
next prev parent reply other threads:[~2017-11-09 12:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 18:30 nvme multipath support V6 Christoph Hellwig
2017-11-02 18:30 ` [PATCH 1/5] nvme: track subsystems Christoph Hellwig
2017-11-09 11:33 ` Sagi Grimberg
2017-11-09 12:53 ` Christoph Hellwig [this message]
2017-11-09 13:01 ` Sagi Grimberg
2017-11-02 18:30 ` [PATCH 2/5] nvme: introduce a nvme_ns_ids structure Christoph Hellwig
2017-11-02 18:30 ` [PATCH 3/5] nvme: track shared namespaces Christoph Hellwig
2017-11-09 11:37 ` Sagi Grimberg
2017-11-09 12:52 ` Christoph Hellwig
2017-11-09 12:59 ` Sagi Grimberg
2017-11-09 13:20 ` Christoph Hellwig
2017-11-09 16:09 ` Sagi Grimberg
2017-11-02 18:30 ` [PATCH 4/5] nvme: implement multipath access to nvme subsystems Christoph Hellwig
2017-11-06 17:03 ` Mike Snitzer
2017-11-08 8:54 ` Christoph Hellwig
2017-11-08 11:18 ` Hannes Reinecke
2017-11-09 9:13 ` Christoph Hellwig
2017-11-09 15:44 ` Hannes Reinecke
2017-11-09 15:51 ` Christoph Hellwig
2017-11-02 18:30 ` [PATCH 5/5] nvme: also expose the namespace identification sysfs files for mpath nodes Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109125356.GB21795@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).