Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: maurosr@linux.vnet.ibm.com (Mauro Rodrigues)
Subject: building nvmetcli in buildroot
Date: Fri, 10 Nov 2017 09:17:42 -0200	[thread overview]
Message-ID: <20171110111741.GA28245@korriban> (raw)
In-Reply-To: <CANqv2T2Uhy__zyQY-tixnfFmCYOZV7y=grmsgtshRkhx6nwoLw@mail.gmail.com>

On Fri, Nov 10, 2017@08:43:05AM +0100, stephane gonauer wrote:
> Hi,
> 
> I dug further into the question to better understand.
> 
> From my understanding the root cause lies in setuptools :
> 
> - buildroot uses --prefix option to set the prefix to $(TARGET_DIR)
> - the setup.cfg from nvmetcli uses -install-script
> - When both options are present, install-script completely overrides
> --prefix and is considered as an absolute path.
> 
> I tried to uses $(TARGET_DIR) inside setup.cfg but it is not evaluated
> when reaching setup.cfg (and it results in a path containing the
> TARGET_DIR and not its value).
> 
> Unless someone knows how to better use setuptools, I don't see a
> solution inside nvmetcli tree
> 
> St?phane

>From the top of my head I don't recall to see a different solution for
this.

Is your buildroot tool opensource? I would like to see how it deals
with python packages.

Also, I'll take a look if there is a different option from setuptools
standpoint.
> 
> 2017-11-09 18:10 GMT+01:00 Christoph Hellwig <hch at lst.de>:
> > I'm perfectly happy to make life for buildroots easier, but nvmetcli
> > is an admin tool that should live in /usr/sbin.  We'll need to find
> > a way for that to still be the default.
> 

  parent reply	other threads:[~2017-11-10 11:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-09 11:48 building nvmetcli in buildroot stephane gonauer
2017-11-09 17:10 ` Christoph Hellwig
2017-11-10  7:43   ` stephane gonauer
2017-11-10  8:19     ` Christoph Hellwig
2017-11-10 11:17     ` Mauro Rodrigues [this message]
2017-11-10 14:31       ` stephane gonauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171110111741.GA28245@korriban \
    --to=maurosr@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox