Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: leonro@mellanox.com (Leon Romanovsky)
Subject: [PATCH 1/3] IB/core: add a simple SRQ pool per PD
Date: Sat, 18 Nov 2017 09:36:56 +0200	[thread overview]
Message-ID: <20171118073656.GS18825@mtr-leonro.local> (raw)
In-Reply-To: <c94d2e03-dd32-ff0a-789f-aae4d65f3955@mellanox.com>

On Fri, Nov 17, 2017@09:12:46PM +0200, Max Gurtovoy wrote:
> > > +#ifndef _RDMA_SRQ_POOL_H
> > > +#define _RDMA_SRQ_POOL_H 1
> > > +
> > > +#include <rdma/ib_verbs.h>
> > > +
> > > +struct ib_srq *ib_srq_pool_get(struct ib_pd *pd);
> > > +void ib_srq_pool_put(struct ib_pd *pd, struct ib_srq *srq);
> > > +
> > > +int ib_srq_pool_init(struct ib_pd *pd, int nr,
> > > +		struct ib_srq_init_attr *srq_attr);
> > > +void ib_srq_pool_destroy(struct ib_pd *pd);
> >
> > Can you please use rdma_ prefix instead of ib_ prefix?
> >
> > Thanks
> >
>
> Do you mean rdma_srq_pool_get instead of ib_srq_pool_get ? is this new
> convetion ? this is a pool that contain ib_srq objects and not rdma_srq
> objects..

I want to follow similar pattern as was chosen for various popular pools
implementation, like dma_pool_, mempool e.t.c

IMHO rdma_srqpool_* looks cleaner than it is now.

Thanks

>
> I can do it if needed.

>
> > > +
> > > +#endif /* _RDMA_SRQ_POOL_H */
> > > --
> > > 1.8.3.1
> > >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-nvme/attachments/20171118/298fd8de/attachment.sig>

  reply	other threads:[~2017-11-18  7:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-16 17:21 [PATCH v2 0/3] nvmet-rdma: SRQ per completion vector Max Gurtovoy
2017-11-16 17:21 ` [PATCH 1/3] IB/core: add a simple SRQ pool per PD Max Gurtovoy
2017-11-16 18:10   ` Leon Romanovsky
2017-11-17 19:12     ` Max Gurtovoy
2017-11-18  7:36       ` Leon Romanovsky [this message]
2017-11-16 18:32   ` Sagi Grimberg
2017-11-17 19:17     ` Max Gurtovoy
2017-11-16 17:21 ` [PATCH 2/3] nvmet-rdma: use srq pointer in rdma_cmd Max Gurtovoy
2017-11-16 17:26   ` [Suspected-Phishing][PATCH " Max Gurtovoy
2017-11-16 18:37   ` [PATCH " Sagi Grimberg
2017-11-16 17:21 ` [PATCH 3/3] nvmet-rdma: use SRQ per completion vector Max Gurtovoy
2017-11-16 18:08 ` [PATCH v2 0/3] nvmet-rdma: " Leon Romanovsky
2017-11-17 19:18   ` Max Gurtovoy
2017-11-16 18:36 ` Sagi Grimberg
2017-11-17 19:32   ` Max Gurtovoy
2017-11-18 12:52     ` Leon Romanovsky
2017-11-18 13:57       ` Max Gurtovoy
2017-11-18 14:40         ` Leon Romanovsky
2017-11-18 21:29           ` Max Gurtovoy
2017-11-20 11:00             ` Sagi Grimberg
2017-11-20 11:34               ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171118073656.GS18825@mtr-leonro.local \
    --to=leonro@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox