From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v3 1/1] nvme-rdma: Fix memory leak during queue allocation
Date: Tue, 28 Nov 2017 15:26:00 +0100 [thread overview]
Message-ID: <20171128142600.GA441@lst.de> (raw)
In-Reply-To: <3d575588-a910-a371-fdb3-cb56afcbabcd@mellanox.com>
On Tue, Nov 28, 2017@04:18:38PM +0200, Max Gurtovoy wrote:
>
>
> On 11/28/2017 2:42 PM, Christoph Hellwig wrote:
>> On Tue, Nov 28, 2017@01:36:47PM +0100, Christoph Hellwig wrote:
>>> Looks good and applied to nvme-4.15.
>>>
>>> In the long run I wonder if we want a real queue state machine intead
>>> of the flags..
>>
>> Actually, that was a little fast. This conflicts with the MR pool
>> switch.
>
> I'll resend f needed.
Yes, please.
>>
>> Also why does it switch from rdma_destroy_qp to ib_destroy_qp?
>>
>
> because the cm_id might be destroyed (see the error flow).
Needs detailed comments please.
prev parent reply other threads:[~2017-11-28 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 17:01 [PATCH v3 1/1] nvme-rdma: Fix memory leak during queue allocation Max Gurtovoy
2017-11-28 12:36 ` Christoph Hellwig
2017-11-28 12:42 ` Christoph Hellwig
2017-11-28 14:18 ` Max Gurtovoy
2017-11-28 14:26 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128142600.GA441@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox