From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 2/2] NVMe-CLI : WDC-Plugin Documentation for Updated Smart Log Command
Date: Wed, 29 Nov 2017 09:38:37 -0700 [thread overview]
Message-ID: <20171129163836.GD24085@localhost.localdomain> (raw)
In-Reply-To: <MWHPR04MB1025D9A09C89FF51CA5BAEACEA3A0@MWHPR04MB1025.namprd04.prod.outlook.com>
On Tue, Nov 28, 2017@04:24:05PM +0000, Jeffrey Lien wrote:
> Yea, I wasn't sure why the auto-generated files are included with the txt file vs just the txt file. It seems to make more sense to push just the txt fail and then regenerate the other files, but that doesn't match what was done in the past.
Push now, thanks.
I'd just recommend unstaging the .html and .1 files before committing,
and I'll generate the docs as needed. It's usually not a problem when
they're included in a pull request, but when conflicts in the generated
files happen, it's easier to fix by regenerating them than trying to
merge. The only reason we have them under source control is to not have
a dependency on asciidoc to install the program.
prev parent reply other threads:[~2017-11-29 16:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 14:29 [PATCH 2/2] NVMe-CLI : WDC-Plugin Documentation for Updated Smart Log Command Jeff Lien
2017-11-28 15:47 ` Keith Busch
2017-11-28 16:24 ` Jeffrey Lien
2017-11-29 16:38 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129163836.GD24085@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox