From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/2] nvme: Take refcount on transport module when using block device operations
Date: Mon, 8 Jan 2018 16:56:50 +0100 [thread overview]
Message-ID: <20180108155650.GA12142@lst.de> (raw)
In-Reply-To: <CAA7jzte5xvqtN44C8TsLNnymQ6v3_9O+TMBsA7VbD9DrWU5Nnw@mail.gmail.com>
On Tue, Jan 09, 2018@12:51:11AM +0900, Minwoo Im wrote:
> Hi Max,
>
> On Fri, Jan 5, 2018@12:56 AM, Max Gurtovoy <maxg@mellanox.com> wrote:
> > + kref_put(&ns->kref, nvme_free_ns);
>
> This seems identical to nvme_put_ns(ns);
> It would look better if replaced with nvme_put_ns() function call just
> like nvme_release()
> that you have updated in this patch.
I've fixed it in the applied patch, thanks!
prev parent reply other threads:[~2018-01-08 15:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 15:56 [PATCH 1/2] nvme: Take refcount on transport module when using block device operations Max Gurtovoy
2018-01-04 15:56 ` [PATCH 2/2] nvme: Fix subsystem multiple controllers support check Max Gurtovoy
2018-01-08 10:14 ` Christoph Hellwig
2018-01-08 10:16 ` Christoph Hellwig
2018-01-08 14:43 ` Israel Rukshin
2018-01-18 13:43 ` Israel Rukshin
2018-01-08 10:12 ` [PATCH 1/2] nvme: Take refcount on transport module when using block device operations Christoph Hellwig
2018-01-08 15:51 ` Minwoo Im
2018-01-08 15:56 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108155650.GA12142@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox