From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH V2] nvme: free pre-allocated queue if create ioq goes wrong
Date: Sun, 14 Jan 2018 19:00:16 -0700 [thread overview]
Message-ID: <20180115020016.GB13580@localhost.localdomain> (raw)
In-Reply-To: <1515963650-3805-1-git-send-email-minwoo.im.dev@gmail.com>
On Mon, Jan 15, 2018@06:00:50AM +0900, Minwoo Im wrote:
> static const struct blk_mq_ops nvme_mq_admin_ops = {
> .queue_rq = nvme_queue_rq,
> .complete = nvme_pci_complete_rq,
> @@ -1637,8 +1636,10 @@ static int nvme_create_io_queues(struct nvme_dev *dev)
> max = min(dev->max_qid, dev->ctrl.queue_count - 1);
> for (i = dev->online_queues; i <= max; i++) {
> ret = nvme_create_queue(dev->queues[i], i);
> - if (ret)
> + if (ret) {
> + nvme_free_queues(dev, dev->online_queues);
> break;
> + }
> }
Unless this is the very first pass at initialisation, I don't think we
can free queues until after blk_mq_update_nr_hw_queues since the hctx
could otherwise point to freed memory.
next prev parent reply other threads:[~2018-01-15 2:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 21:00 [PATCH V2] nvme: free pre-allocated queue if create ioq goes wrong Minwoo Im
2018-01-15 2:00 ` Keith Busch [this message]
2018-01-17 13:07 ` Minwoo Im
2018-01-17 15:00 ` Minwoo Im
2018-01-18 5:27 ` jianchao.wang
2018-01-18 10:25 ` Minwoo Im
2018-01-18 11:31 ` Keith Busch
2018-01-18 22:52 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115020016.GB13580@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox