From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme-pci: take sglist coalescing in dma_map_sg into account
Date: Mon, 15 Jan 2018 18:50:16 -0700 [thread overview]
Message-ID: <20180116015016.GD32369@localhost.localdomain> (raw)
In-Reply-To: <20180115173716.22409-1-hch@lst.de>
On Mon, Jan 15, 2018@06:37:16PM +0100, Christoph Hellwig wrote:
> Some iommu implementations can merge physically and/or virtually
> contiguous segments inside sg_map_dma. The NVMe SGL support does not take
> this into account and will warn because of falling off a loop. Pass the
> number of mapped segments to nvme_pci_setup_sgls so that the SGL setup
> can take the number of mapped segments into account.
>
> Reported-by: Fangjian (Turing) <f.fangjian at huawei.com>
> Fixes: a7a7cbe3 ("nvme-pci: add SGL support")
> Signed-off-by: Christoph Hellwig <hch at lst.de>
This looks fine, but I think keeping tabs on on the mapped length wouldn't
hurt since a mismatch is a software bug that would be difficult to debug
later. But if you trust it's not necessary, that's good enough for me.
next prev parent reply other threads:[~2018-01-16 1:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 17:37 [PATCH] nvme-pci: take sglist coalescing in dma_map_sg into account Christoph Hellwig
2018-01-16 1:50 ` Keith Busch [this message]
2018-01-17 8:30 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116015016.GD32369@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox