From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v4 1/2] nvme: add tracepoint for nvme_setup_cmd
Date: Mon, 22 Jan 2018 16:59:56 +0100 [thread overview]
Message-ID: <20180122155956.GA6635@lst.de> (raw)
In-Reply-To: <20180122155356.4doy32sfgzwegmq4@linux-x5ow.site>
On Mon, Jan 22, 2018@04:53:56PM +0100, Johannes Thumshirn wrote:
> Yes and no. I personally like to have the big hammer when tracing customer
> problems and filter out maunally later. I initially had a tracepoint for each
> of nvme_setup_flush(), nvme_setup_discard(), nvme_setup_rw() but decided it
> was too fine grained.
>
> nvme_setup_cmd() has the nice side effect that all commands, including
> userspace passtrough commands must pass it. This was extremely helpful in the
> customer bug which inspired me to implement this tracepoint.
Not arguing against placing the tracepoint(s) in nvme_setup_cmd, but
it seems like we should have one for admin and one for I/O commands.
Especially as we have to special case them just about everywhere,
and the overlap of the opcode space is pretty annoying.
next prev parent reply other threads:[~2018-01-22 15:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 14:18 [PATCH v4 0/2] add tracepoints for nvme command submission and completion Johannes Thumshirn
2018-01-19 14:18 ` [PATCH v4 1/2] nvme: add tracepoint for nvme_setup_cmd Johannes Thumshirn
2018-01-22 15:23 ` Christoph Hellwig
2018-01-22 15:53 ` Johannes Thumshirn
2018-01-22 15:59 ` Christoph Hellwig [this message]
2018-01-22 16:04 ` Johannes Thumshirn
2018-01-22 16:10 ` Christoph Hellwig
2018-01-22 16:15 ` Johannes Thumshirn
2018-01-19 14:18 ` [PATCH v4 2/2] nvme: add tracepoint for nvme_complete_rq Johannes Thumshirn
2018-01-22 15:23 ` Christoph Hellwig
2018-01-22 15:30 ` Johannes Thumshirn
2018-01-22 19:35 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122155956.GA6635@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).