* [PATCH 1/1] nvme-rdma: remove redundant boolean for inline_data
@ 2017-12-06 16:21 Max Gurtovoy
2017-12-07 6:40 ` Sagi Grimberg
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Max Gurtovoy @ 2017-12-06 16:21 UTC (permalink / raw)
Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
---
drivers/nvme/host/rdma.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 37af565..225f7f1 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -66,7 +66,6 @@ struct nvme_rdma_request {
struct ib_sge sge[1 + NVME_RDMA_MAX_INLINE_SEGMENTS];
u32 num_sge;
int nents;
- bool inline_data;
struct ib_reg_wr reg_wr;
struct ib_cqe reg_cqe;
struct nvme_rdma_queue *queue;
@@ -1086,7 +1085,6 @@ static int nvme_rdma_map_sg_inline(struct nvme_rdma_queue *queue,
sg->length = cpu_to_le32(sg_dma_len(req->sg_table.sgl));
sg->type = (NVME_SGL_FMT_DATA_DESC << 4) | NVME_SGL_FMT_OFFSET;
- req->inline_data = true;
req->num_sge++;
return 0;
}
@@ -1158,7 +1156,6 @@ static int nvme_rdma_map_data(struct nvme_rdma_queue *queue,
int count, ret;
req->num_sge = 1;
- req->inline_data = false;
refcount_set(&req->ref, 2); /* send and recv completions */
c->common.flags |= NVME_CMD_SGL_METABUF;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 1/1] nvme-rdma: remove redundant boolean for inline_data
2017-12-06 16:21 [PATCH 1/1] nvme-rdma: remove redundant boolean for inline_data Max Gurtovoy
@ 2017-12-07 6:40 ` Sagi Grimberg
2018-01-24 15:57 ` Max Gurtovoy
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Sagi Grimberg @ 2017-12-07 6:40 UTC (permalink / raw)
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 1/1] nvme-rdma: remove redundant boolean for inline_data
2017-12-06 16:21 [PATCH 1/1] nvme-rdma: remove redundant boolean for inline_data Max Gurtovoy
2017-12-07 6:40 ` Sagi Grimberg
@ 2018-01-24 15:57 ` Max Gurtovoy
2018-01-25 8:35 ` Johannes Thumshirn
2018-01-25 15:23 ` Christoph Hellwig
3 siblings, 0 replies; 5+ messages in thread
From: Max Gurtovoy @ 2018-01-24 15:57 UTC (permalink / raw)
ping :)
On 12/6/2017 6:21 PM, Max Gurtovoy wrote:
> Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
> ---
> drivers/nvme/host/rdma.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index 37af565..225f7f1 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -66,7 +66,6 @@ struct nvme_rdma_request {
> struct ib_sge sge[1 + NVME_RDMA_MAX_INLINE_SEGMENTS];
> u32 num_sge;
> int nents;
> - bool inline_data;
> struct ib_reg_wr reg_wr;
> struct ib_cqe reg_cqe;
> struct nvme_rdma_queue *queue;
> @@ -1086,7 +1085,6 @@ static int nvme_rdma_map_sg_inline(struct nvme_rdma_queue *queue,
> sg->length = cpu_to_le32(sg_dma_len(req->sg_table.sgl));
> sg->type = (NVME_SGL_FMT_DATA_DESC << 4) | NVME_SGL_FMT_OFFSET;
>
> - req->inline_data = true;
> req->num_sge++;
> return 0;
> }
> @@ -1158,7 +1156,6 @@ static int nvme_rdma_map_data(struct nvme_rdma_queue *queue,
> int count, ret;
>
> req->num_sge = 1;
> - req->inline_data = false;
> refcount_set(&req->ref, 2); /* send and recv completions */
>
> c->common.flags |= NVME_CMD_SGL_METABUF;
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 1/1] nvme-rdma: remove redundant boolean for inline_data
2017-12-06 16:21 [PATCH 1/1] nvme-rdma: remove redundant boolean for inline_data Max Gurtovoy
2017-12-07 6:40 ` Sagi Grimberg
2018-01-24 15:57 ` Max Gurtovoy
@ 2018-01-25 8:35 ` Johannes Thumshirn
2018-01-25 15:23 ` Christoph Hellwig
3 siblings, 0 replies; 5+ messages in thread
From: Johannes Thumshirn @ 2018-01-25 8:35 UTC (permalink / raw)
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] nvme-rdma: remove redundant boolean for inline_data
2017-12-06 16:21 [PATCH 1/1] nvme-rdma: remove redundant boolean for inline_data Max Gurtovoy
` (2 preceding siblings ...)
2018-01-25 8:35 ` Johannes Thumshirn
@ 2018-01-25 15:23 ` Christoph Hellwig
3 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2018-01-25 15:23 UTC (permalink / raw)
Thanks,
applied to nvme-4.16.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-25 15:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-06 16:21 [PATCH 1/1] nvme-rdma: remove redundant boolean for inline_data Max Gurtovoy
2017-12-07 6:40 ` Sagi Grimberg
2018-01-24 15:57 ` Max Gurtovoy
2018-01-25 8:35 ` Johannes Thumshirn
2018-01-25 15:23 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).