Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] NVMe-CLI Fix command failures in regress script
Date: Mon, 5 Feb 2018 12:34:16 -0700	[thread overview]
Message-ID: <20180205193416.GC31110@localhost.localdomain> (raw)
In-Reply-To: <MWHPR04MB1025C0DF9D330E1B0DC5CFBEEAFE0@MWHPR04MB1025.namprd04.prod.outlook.com>

On Mon, Feb 05, 2018@07:00:58PM +0000, Jeffrey Lien wrote:
> Ok, that makes sense.  I should have thought to try that; sorry for the trouble.   
> 
> I did find 2 other problems/failures when using the block device though:
> 1)  The flush command has a default namespace id of All ID's (0xffffffff) which causes it to fail.  So to fix that either:
>     * The default ns id has to change for the flush command or 
>     * The "-n 1" parm needs to be added to the flush command in the regress script 

I will change nvme-cli to use the block handle NSID no problem, but
isn't Flush the only IO command that is required to support the
broadcast NSID? I know the wording was a bit vague on using this value
and there was discussion on the technical reflector about it, but I
haven't had time to read into where they're going with it.

> 2) The --block-count=0 setting in the read/write commands fails when the nvme drive is formatted with a lba data size of 512 bytes.  Setting it to 8 seems to work for both  512 and 4k bytes lba data size.  

Oops, the regress script has hard-coded an expected 4k LBA format. We need
it to discover and be re-active to the format instead.

      reply	other threads:[~2018-02-05 19:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-02 19:50 [PATCH] NVMe-CLI Fix command failures in regress script Jeff Lien
2018-02-02 20:29 ` Keith Busch
2018-02-02 21:33   ` Jeffrey Lien
2018-02-02 21:38     ` Keith Busch
2018-02-05 16:49       ` Jeffrey Lien
2018-02-05 16:57         ` Keith Busch
2018-02-05 19:00           ` Jeffrey Lien
2018-02-05 19:34             ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180205193416.GC31110@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox