From mboxrd@z Thu Jan  1 00:00:00 1970
From: alex.nlnnfn@gmail.com (Alex Nln)
Date: Mon, 5 Feb 2018 21:39:45 -0800
Subject: coalescing in polling mode in 4.9
In-Reply-To: <7d378937-1859-0007-12b3-ca1722d2a5c3@samsung.com>
References: <20180202001028.fee27cf239e3e8a5ae6bd8a4@gmail.com>
 <CGME20180205145924epcas3p2f8156043ec00b51c135ac62c1fa177d7@epcas3p2.samsung.com>
 <20180205150253.GN24417@localhost.localdomain>
 <7d378937-1859-0007-12b3-ca1722d2a5c3@samsung.com>
Message-ID: <20180205213945.303b3a69a7048d94cecac599@gmail.com>

Hi Nitesh,

On Mon, 05 Feb 2018 21:12:12 +0530
Nitesh <nj.shetty@samsung.com> wrote:

> Hi Alex,
> I got into similar problem not long ago. With coalescing enabled, some 
> I/Os took very long. Every time need_reshed() returns true, 
> io_schedule() makes task go to sleep as its state is previous set as 
> non-interruptible.I handled this by setting task state as running, and 
> release the cpu. Diff is attached below, you may give it a try.
> 

I tested this patch on kernel 4.9 and it solves the problem.
Thanks a lot


> 
> diff --git a/fs/block_dev.c b/fs/block_dev.c
> index 4a181fc..d2eeedf 100644
> --- a/fs/block_dev.c
> +++ b/fs/block_dev.c
> @@ -236,9 +236,13 @@ __blkdev_direct_IO_simple(struct kiocb *iocb, 
> struct iov_iter *iter,
>                  set_current_state(TASK_UNINTERRUPTIBLE);
>                  if (!READ_ONCE(bio.bi_private))
>                          break;
> -               if (!(iocb->ki_flags & IOCB_HIPRI) ||
> -                   !blk_poll(bdev_get_queue(bdev), qc))
> +               if (!(iocb->ki_flags & IOCB_HIPRI))
>                          io_schedule();
> +               else if (!blk_poll(bdev_get_queue(bdev), qc)) {
> +                       if(need_resched())
> +                               set_current_state(TASK_RUNNING);
> +                       io_schedule();
> +               }
>          }
>          __set_current_state(TASK_RUNNING);
> 
>