From: keith.busch@intel.com (Keith Busch)
Subject: coalescing in polling mode in 4.9
Date: Tue, 6 Feb 2018 09:29:04 -0700 [thread overview]
Message-ID: <20180206162903.GF31110@localhost.localdomain> (raw)
In-Reply-To: <7d378937-1859-0007-12b3-ca1722d2a5c3@samsung.com>
On Mon, Feb 05, 2018@09:12:12PM +0530, Nitesh wrote:
> diff --git a/fs/block_dev.c b/fs/block_dev.c
> index 4a181fc..d2eeedf 100644
> --- a/fs/block_dev.c
> +++ b/fs/block_dev.c
> @@ -236,9 +236,13 @@ __blkdev_direct_IO_simple(struct kiocb *iocb, struct
> iov_iter *iter,
> set_current_state(TASK_UNINTERRUPTIBLE);
> if (!READ_ONCE(bio.bi_private))
> break;
> - if (!(iocb->ki_flags & IOCB_HIPRI) ||
> - !blk_poll(bdev_get_queue(bdev), qc))
> + if (!(iocb->ki_flags & IOCB_HIPRI))
> io_schedule();
> + else if (!blk_poll(bdev_get_queue(bdev), qc)) {
> + if(need_resched())
> + set_current_state(TASK_RUNNING);
> + io_schedule();
> + }
> }
> __set_current_state(TASK_RUNNING);
Yah, I think this looks good. Do you want to send this as a proper patch
to linux-block mailing list for consideration?
next prev parent reply other threads:[~2018-02-06 16:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 8:10 coalescing in polling mode in 4.9 Alex Nln
2018-02-05 0:15 ` Alex Nln
2018-02-05 14:40 ` Sagi Grimberg
2018-02-05 15:02 ` Keith Busch
2018-02-05 15:42 ` Nitesh
2018-02-06 5:39 ` Alex Nln
2018-02-09 22:37 ` Nitesh Shetty
2018-02-10 21:08 ` Alex Nln
2018-02-12 14:53 ` Keith Busch
2018-02-06 16:29 ` Keith Busch [this message]
2018-02-07 8:27 ` Nitesh
2018-02-06 3:55 ` Alex Nln
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206162903.GF31110@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox