From mboxrd@z Thu Jan 1 00:00:00 1970 From: keith.busch@intel.com (Keith Busch) Date: Tue, 20 Feb 2018 09:27:37 -0700 Subject: [PATCH] blk: optimization for classic polling In-Reply-To: <20180220132137.GG25314@hirez.programming.kicks-ass.net> References: <3578876466-3733-1-git-send-email-nj.shetty@samsung.com> <20180220132137.GG25314@hirez.programming.kicks-ass.net> Message-ID: <20180220162737.GC7076@localhost.localdomain> On Tue, Feb 20, 2018@02:21:37PM +0100, Peter Zijlstra wrote: > Also, set_current_state(TASK_RUNNING) is dodgy (similarly in > __blk_mq_poll), why do you need that memory barrier? You're right. The subsequent revision that was committed removed the barrier. The commit is here: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=67b4110f8c8d16e588d7730db8e8b01b32c1bd8b I hope the code at least looks more reasonable. The changelog isn't much different, though.